chore: have mypy import stub libraries by default#11
Merged
averikitsch merged 4 commits intomainfrom Jan 26, 2024
Merged
Conversation
jackwotherspoon
commented
Jan 26, 2024
Contributor
Author
|
Looks like integration test build fails when no tests are run, can ignore |
jackwotherspoon
commented
Jan 26, 2024
averikitsch
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most libraries have stub packages for types. Adding
--install-typeswill have mypy install them by default and not require them to be added to any deps.Alternative is to add a poetry group for
typingand add all required stubs to it: https://github.com/langchain-ai/langchain/blob/master/libs/core/pyproject.toml#L32